[3.0] Respect attempts and timeout from resolv.conf#231
Open
WyriHaximus wants to merge 3 commits intoreactphp:3.xfrom
Open
[3.0] Respect attempts and timeout from resolv.conf#231WyriHaximus wants to merge 3 commits intoreactphp:3.xfrom
attempts and timeout from resolv.conf#231WyriHaximus wants to merge 3 commits intoreactphp:3.xfrom
Conversation
WyriHaximus
changed the title
attempts and timeout from resolv.conf
WyriHaximus
force-pushed
the
3.x-respect-attempts-and-timeout-from-resolv.conf
branch
from
d75f553 to
c78b412
Compare
…options The two current supported options, `attempts` and `timeout`, have their min (assumed to be `1`), max, and default value as specified on https://man7.org/linux/man-pages/man5/resolv.conf.5.html set.
Adding parsing logic to the `Config` class that respects values as specified on https://man7.org/linux/man-pages/man5/resolv.conf.5.html in such a way we can easily expand the list to add `search`, `ndots`, and more in follow up PRs. As per https://man7.org/linux/man-pages/man5/resolv.conf.5.html both values are silently capped and are not allowed to go below 1.
WyriHaximus
force-pushed
the
3.x-respect-attempts-and-timeout-from-resolv.conf
branch
from
df07956 to
71837b3
Compare
While setting up the executors we will now use the `Options` class to pass in formally hardcoded values. This won't impact current behavior unless `resolv.conf` other than default values. A small note is added to the readme documenting the behavior introduced in this PR.
WyriHaximus
force-pushed
the
3.x-respect-attempts-and-timeout-from-resolv.conf
branch
from
71837b3 to
766ba63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commits in this PR add representation, parsing, and utilisation of
attemptsandtimeoutoptions fromresolv.conf.Based on https://man7.org/linux/man-pages/man5/resolv.conf.5.html the limits for both options have been silently capped, and for both, the assumption is made that the lowest possible value is
1.Builds the foundation for #231 that will implement #158. Building on top of #187, #179, #180, and many others.